Skip to content

Revert "Do not mark wheel as universal" #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

graingert
Copy link
Member

@graingert graingert commented May 7, 2020

Reverts #187

the package already has a valid python_requires:

https://github.com/pytest-dev/pytest-mock/blob/master/setup.py#L11
I think removing the py2 tag from the wheel will cause pip on py2 to download the sdist before seeing the python_requires

@graingert graingert marked this pull request as draft May 7, 2020 11:57
@The-Compiler
Copy link
Member

What's the point of marking the wheel py2-compatible if it isn't? From https://packaging.python.org/guides/distributing-packages-using-setuptools/#universal-wheels:

Only use the --universal setting, if:

  1. Your project runs on Python 2 and 3 with no changes (i.e. it does not require 2to3).
  2. Your project does not have any C extensions.

and

Pure Python Wheels that are not “universal” are wheels that are pure Python (i.e. contain no compiled extensions), but don’t natively support both Python 2 and 3.

@graingert graingert closed this May 7, 2020
@nicoddemus nicoddemus deleted the revert-187-do-not-mark-wheel-as-universal branch May 7, 2020 12:11
@graingert
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants