Feat: log other quoters #521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
guibescos
reviewed
Apr 22, 2025
| @@ -135,6 +140,21 @@ impl TokenAccountInitializationConfigs { | |||
| } | |||
| } | |||
|
|
|||
| #[serde_as] | |||
| #[derive(Clone, Debug, PartialEq, Serialize, Deserialize)] | |||
| pub struct OtherQuote { | |||
There was a problem hiding this comment.
Should this be exposed to searchers through the API?
guibescos
reviewed
Apr 22, 2025
| @@ -89,6 +90,7 @@ pub struct OpportunityMetadataSvmProgramSwap { | |||
| #[serde(default = "default_cancellable")] | |||
| pub cancellable: bool, | |||
| pub minimum_lifetime: Option<u32>, | |||
| pub other_quotes: Vec<OtherQuote>, | |||
There was a problem hiding this comment.
It doesn't feel great to have such a big struct here.
Could we alternatively just return the searcher token amount?
Dewyer
reviewed
Apr 22, 2025
| @@ -324,6 +391,8 @@ impl Service { | |||
| referral_fee_info.referral_fee_bps, | |||
| ); | |||
|
|
|||
| let other_quotes = self.get_other_quotes(quote_create.clone()).await; | |||
There was a problem hiding this comment.
maybe we could defer fetching this
Dewyer
reviewed
Apr 22, 2025
| Ok(config) => config, | ||
| Err(_) => return vec![], | ||
| }; | ||
| let ultra_client = &config.jupiter_ultra_client; |
There was a problem hiding this comment.
also maybe we could make it optional, ie if its disabled in the config we don't try to make a call at all
Dewyer
reviewed
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the basic logic to log the responses of other quoters whenever a quote request is created. The other quoters' info is stored in the opportunity metadata. This PR leverages a Rust crate derived from this fork of the Jupiter Swap API client, to source quotes from the Jupiter Ultra endpoint.
Currently the other quoters' info is added to the opportunity retroactively following the creation and broadcasting of the opportunity.
TODOs