deps: Upgrade redis stubs #399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 11 11
Lines 1052 1052
Branches 199 199
=======================================
Hits 1038 1038
Misses 6 6
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
|
The pipeline types aren't being inferred correctly due to mypy. If the latest mypy version is used, those hints are no longer needed. I've submitted #403 to update mypy, but it'll conflict with your PR. If this PR is merged first I can rebase and add a commit to remove the hints. |
rossmacarthur
pushed a commit
to hunchdata/arq
that referenced
this pull request
Mar 4, 2024
|
Thanks so much for the contribution, this is replaced by #439 where I've fixed lots of related things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick clean-up PR. Noticed there were a lot of Redis-pipeline
mypyerrors that shouldn't occur with the latest version of types-redis.Not 100% sure if
Pipeline[bytes]is the appropriate annotation here, so please let me know if not. Also, if you have a better suggestion for how to fix types inference for the pipeline variables, that's of course very welcome; the manual definitions are not ideal.