Skip to content

Use trusted publishing for package uploads #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

krassowski
Copy link
Member

Use trusted publishing for package uploads

@krassowski krassowski requested a review from Copilot May 2, 2025 15:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve package upload security by using trusted publishing.

  • Upgrades the Python version from 3.8 to 3.9 in the workflow.
  • Splits the publishing flow into a "build" job that uploads artifacts and a "pypi-publish" job that downloads the artifacts and publishes the package to PyPI using the trusted publishing action.

Co-authored-by: Copilot <[email protected]>
@krassowski krassowski requested a review from Copilot May 2, 2025 15:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements trusted publishing for package uploads by separating the build and publish processes in the GitHub Actions workflow.

  • Upgraded Python version from 3.8 to 3.9.
  • Split the workflow into a build job that uploads an artifact and a pypi-publish job that downloads the artifact and publishes to PyPI.
Comments suppressed due to low confidence (1)

.github/workflows/publish.yml:25

  • [nitpick] The artifact name contains spaces and uses a non-standard format. Consider renaming it to a more conventional format such as "docstring-to-markdown-dist-${{ github.run_number }}" to improve clarity and consistency.
name: docstring-to-markdown dist ${{ github.run_number }}

@krassowski krassowski merged commit 1cdc9e1 into python-lsp:main May 2, 2025
7 checks passed
@krassowski krassowski deleted the trusted-publisher branch May 2, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant