-
-
Notifications
You must be signed in to change notification settings - Fork 354
Switch from PurePath#as_uri
to PurePath#joinpath
for our test that PurePath methods get inherited
#3249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`as_uri` is deprecated in `PurePath`. This commit also introduces a test to ensure users have a workaround that is not deprecated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3249 +/- ##
================================================
Coverage 100.00000% 100.00000%
================================================
Files 122 124 +2
Lines 18757 19005 +248
Branches 1269 1295 +26
================================================
+ Hits 18757 19005 +248
🚀 New features to boost your workflow:
|
IMO we should define a sync and then I think the test change is just to find a different |
I wasn't too sure about doing that because there's no fundamental reason that has to be on And users can do |
IMO "maintaining 1:1 compatibility with existing code" is enough reason in this case, and right now unblocking CI feels more urgent than answering those other API design questions 😅 (but for completeness: I'd like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks for jumping on this @A5rocks!
as_uri
is deprecated inPurePath
. This commit also introduces a test to ensure users have a workaround that is not deprecated.Failing test run: https://github.com/python-trio/trio/actions/runs/14393482504/job/40364976912