Add the GeoMan plugin #2124
Merged
Add the GeoMan plugin #2124
+132
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GeoMan plugin is like the Draw plugin, with extra functionality, such as support for Polygons with holes.
|
@ocefpaf can you have a look? |
ocefpaf
reviewed
Apr 22, 2025
| default_js = [ | ||
| ( | ||
| "leaflet_geoman_js", | ||
| "https://unpkg.com/@geoman-io/leaflet-geoman-free@latest/dist/leaflet-geoman.js", |
There was a problem hiding this comment.
Should we use a versioned URL here? I'm also on the fence when doing this for plugins.
BTW, I would recommend all new plugins to be their own package. However, this one does make sense to be here IMO.
There was a problem hiding this comment.
My preference is for unversioned most of the time. It causes a lot of small annoyances every time something breaks. It avoids being unable to bring a plugin up to date because too much time has passed and the old versions are no longer supported.
What do you mean "their own package"? You mean like a separate github repository?
There was a problem hiding this comment.
Yep. We took that approach to
- Decoupled the plunging development and release from folium
- Avoid the extra maintenance burden
ocefpaf
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GeoMan plugin is like the Draw plugin, with extra functionality, such as support for Polygons with holes.