Issue 1877: Fix _to_png when using fit_bounds
#2135
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansthen
changed the title
_to_png when using fit_bounds_to_png when using fit_bounds
|
@ocefpaf can you have a look? |
Indeed a breaking change, but in a way to_png was always an experimental feature, so I'm fine with the updated behavior that, IMO, is better. |
ocefpaf
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1877
Beware, this change may break existing behavior. Previously all the images were generated against a full screen version of the map, even if the code contained a
fit_boundsstatement. We need to decide if this is a feature or a bug.I did add a new parameter to
_to_png()that allows the caller to set the size of the resulting image.