Skip to content

Issue 1770: Add on_each_feature handler to GeoJson #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

hansthen
Copy link
Collaborator

@hansthen hansthen commented Apr 18, 2025

Close #1770.

This will allow users to customize the Tooltips and Popups for GeoJson data. It should also help with issue #1520.

Testing was done manually, using a streamlit program.

This will allow users to customize the Tooltips and Popups
for the GeoJson data. It should also help with issue python-visualization#1520.

Testing was done manually, using a streamlit program.
@hansthen hansthen changed the title Add on_each_feature handler to GeoJson Issue 1770: Add on_each_feature handler to GeoJson Apr 19, 2025
@hansthen hansthen requested review from ocefpaf and Conengmo April 19, 2025 05:33
@hansthen
Copy link
Collaborator Author

@ocefpaf can you have a look?

@ocefpaf
Copy link
Member

ocefpaf commented Apr 22, 2025

Testing was done manually, using a streamlit program.

Is there any testing we can do here? To check if the rendering as expected?

@hansthen
Copy link
Collaborator Author

Testing was done manually, using a streamlit program.

Is there any testing we can do here? To check if the rendering as expected?

I have a proposal for regression testing in the playwright branch. It makes use of Playwrights visual snapshots to compare the current version against stored images under version control.

However, when working on the #1877 issue, I got an idea that may be even simpler. We can use _to_png() with fixed size to make visual snapshots.

I have a boatload of regression tests that I'd like to check in. I think it would make folium development much more solid if we had better snapshot testing.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 22, 2025

Got it. Looks like a small code change with a larger impact. While I'm OK merging this as-is not. I would like an issue to track the development of the tests. What do you think?

@hansthen
Copy link
Collaborator Author

I created an issue for the regression tests: #2140.

@hansthen hansthen merged commit 764c691 into python-visualization:main Apr 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GeoJsonToolTips/GeoJsonPopup when using GeoJson together with the marker cluster plugin
2 participants