Skip to content

Allow logging.handlers.QueueListener to be used as a context manager #132106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csm10495 opened this issue Apr 5, 2025 · 0 comments
Closed

Allow logging.handlers.QueueListener to be used as a context manager #132106

csm10495 opened this issue Apr 5, 2025 · 0 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@csm10495
Copy link
Contributor

csm10495 commented Apr 5, 2025 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

This is a simple change that would allow:

         with QueueListener(queue, handler1) as listener:
             # the listener has started
             ...
         # the listener has stopped

It's a welcomed alternative to needing to call start/stop manually.

Has this already been discussed elsewhere?

I have already discussed this feature proposal on Discourse

Links to previous discussion of this feature:

https://discuss.python.org/t/allow-logging-handlers-queuelistener-to-be-used-as-a-context-manager/87124

Linked PRs
@csm10495 csm10495 added the type-feature A feature request or enhancement label Apr 5, 2025
@csm10495 csm10495 mentioned this issue Apr 5, 2025
Merged
@picnixz picnixz added the stdlib Python modules in the Lib dir label Apr 5, 2025
picnixz pushed a commit that referenced this issue Apr 12, 2025
@csm10495
gh-132106: Allow logging.handlers.QueueListener to be used as a con…
517e96b 
…text manager (#132107)
csm10495 added a commit to csm10495/cpython that referenced this issue Apr 12, 2025
@csm10495
pythongh-132106 - Make it so start can't be called again while running
1f5163e 
Prevents a thread leak
csm10495 added a commit to csm10495/cpython that referenced this issue Apr 12, 2025
@csm10495
pythongh-132106 - Make it so start can't be called again while running
4a907d8 
Prevents a thread leak
@csm10495 csm10495 mentioned this issue Apr 12, 2025
Merged
vsajip pushed a commit that referenced this issue Apr 13, 2025
@csm10495
gh-132106: Ensure that running logging.handlers.QueueListener canno…
5863cd7 
…t be started again (GH-132444)

Prevents a thread leak
Co-authored-by: Bénédikt Tran <[email protected]>
vsajip pushed a commit to vsajip/cpython that referenced this issue Apr 13, 2025
@csm10495 @vsajip
[3.13] pythongh-132106: Ensure that running `logging.handlers.QueueLi…
582b593 
…stener` cannot be started again (pythonGH-132444)

Prevents a thread leak
Co-authored-by: Bénédikt Tran <[email protected]>
(cherry picked from commit 5863cd7)

Co-authored-by: Charles Machalow <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Apr 13, 2025
Merged
vsajip added a commit that referenced this issue Apr 13, 2025
@vsajip
[3.13] gh-132106: Ensure that running `logging.handlers.QueueListener… (
1dcdac6 
GH-132471)

Cherry-picked using 5863cd7
@vsajip vsajip closed this as completed Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
Logging issues 🪵
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vsajip @csm10495 @picnixz