-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-132106: Allow logging.handlers.QueueListener to be used as a context manager #132107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Brian Schubert <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
…e running (prevents a thread leak) Update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if we can make the multi-start check in a separate PR so that it becomes much easier to revert commits if needs arise. You can re-use the same issue however. We would then merge this PR afterwards (I'll make it so that we don't hang too much on this PR)
@picnixz , I removed the listener already started stuff. I'll do a fresh PR after this one merges (since otherwise I'll merge conflict anyways with this one).. (Unless you'd like that one first instead?) |
Thank you! whichsoever order is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest removing the skipUnless ... QueueHandler
decorators. Otherwise LGTM, thanks!
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…lways available now
I have made the requested changes; please review again |
Thanks for making the requested changes! @vsajip: please review the changes made to this pull request. |
Thanks for the work. You can now fixup the multiple start issue in a new PR but with the same issue number. |
|
📚 Documentation preview 📚: https://cpython-previews--132107.org.readthedocs.build/