Skip to content

gh-128657: Skip test_get_builtin_constructor when running with --parallel-threads #130018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 11, 2025

The test modifies sys.modules and is not thread-safe with --parallel-threads.

…--parallel-threads

The test modifies sys.modules and is not thread-safe.
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Feb 11, 2025
@colesbury
Copy link
Contributor Author

Test failure seen here:

https://github.com/python/cpython/actions/runs/13272459564/job/37054979703

test test_hashlib failed -- Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_hashlib.py", line 278, in test_get_builtin_constructor
    constructor = get_builtin_constructor('md5')
  File "/home/runner/work/cpython/cpython/Lib/hashlib.py", line 123, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5

@colesbury colesbury marked this pull request as ready for review February 11, 2025 21:50
@colesbury colesbury requested a review from mpage February 11, 2025 21:50
@colesbury colesbury merged commit 1f233f5 into python:main Feb 11, 2025
48 checks passed
@colesbury colesbury deleted the gh-128657-hashlib-skip branch February 11, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants