Check kwargs key type as covariant #10223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.named_type('builtins.unicode')]) | ||
| kwargs_type = self.chk.named_generic_type( | ||
| 'typing.Mapping', [key_type, AnyType(TypeOfAny.special_form)]) | ||
| kwargs_type.type.defn.type_vars[0].variance = COVARIANT |
There was a problem hiding this comment.
Wouldn't this affect all uses of Mapping after this code runs?
There was a problem hiding this comment.
Ahh, you're right. Didn't realized that before.
There was a problem hiding this comment.
The fix I was thinking was something along these lines.
Suggested change
| kwargs_type.type.defn.type_vars[0].variance = COVARIANT | |
| is_subtype(typ, self.chk.named_type('typing.Mapping')) and isinstance(typ.args[0], LiteralType) |
This wouldn't cover the case of Literal["a", "b"] but you can try using the try_getting_str_literals_from_type method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10023.
Assume mapping's key type is covariant when validating
**kwargsargument type.