Skip to content

patch: apply menu updates for relevant types only #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pintza
Copy link

@pintza pintza commented Apr 1, 2025

This PR:

  • Modifying the updateMenu function to only await the specific image type needed for the current context
  • Maintain a promise cache to avoid repetitive calls.
  • Improving error handling by properly catching and logging errors without affecting the UI

The changes optimize performance by ensuring that only the necessary image data is loaded when displaying checkpoints or loras in the menu.
These optimizations are particularly beneficial when dealing with large checkpoint or lora remote libraries, as they reduce unnecessary networking and accelerate the ComfyUI GUI load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant