Skip to content

Added GIF and video support in ImageFeed for VHS-VideoCombine output #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dyamagishi
Copy link

Summary

  • Enabled animated GIF/WebP and video display in ImageFeed for output from the "Video Helper Suite - VideoCombine" node.
  • Added a setting "🐍 Image Feed Enable VHS-VideoCombine" to allow users to choose whether to use this feature.

With this, the benefits of the ImageFeed feature can now be applied to video generation as well.

About the Different Output Formats of VideoCombine

Output from the VideoCombine node/videohelpersuite/nodes.py#L620:

return {"ui": {"gifs": [preview]}, "result": ((save_output, output_files),)}

The preview includes the following:

{
    "filename": file,
    "subfolder": subfolder,
    "type": "output" if save_output else "temp",
    "format": format,
    "frame_rate": frame_rate,  # Additional metadata
    "workflow": first_image_file,
    "fullpath": output_files[-1],
}

Issue: Since VideoCombine outputs via ui.gifs, it is not picked up by ImageFeed's ui.images monitoring.


(This is not a standard feature of ComfyUI, but rather support for a custom node — what are your thoughts on this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant