Added GIF and video support in ImageFeed for VHS-VideoCombine output #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this, the benefits of the ImageFeed feature can now be applied to video generation as well.
About the Different Output Formats of VideoCombine
Output from the VideoCombine node/videohelpersuite/nodes.py#L620:
The
preview
includes the following:Issue: Since VideoCombine outputs via
ui.gifs
, it is not picked up by ImageFeed'sui.images
monitoring.(This is not a standard feature of ComfyUI, but rather support for a custom node — what are your thoughts on this?)