Skip to content

Expose tile.id #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Expose tile.id #188

merged 1 commit into from
Jun 17, 2025

Conversation

joydddd
Copy link
Contributor

@joydddd joydddd commented Jun 16, 2025 •
edited
Loading

Stacked PRs:

Expose tile.id

joydddd added a commit that referenced this pull request Jun 16, 2025
@joydddd
Expose tile.id
d70f9d8 
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd mentioned this pull request Jun 16, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 16, 2025
@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:18
joydddd added a commit that referenced this pull request Jun 16, 2025
@joydddd
Expose tile.id
cf0616d 
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from main to joydddd/stack/3 June 16, 2025 23:18
@joydddd joydddd marked this pull request as ready for review June 16, 2025 23:21
@joydddd
Copy link
Contributor Author

joydddd commented Jun 16, 2025

Unit test test_indexing.test_tile_id_2d_indexing skipped due to bug: #185 Please enable after the bug is fixed~

@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:31
joydddd added a commit that referenced this pull request Jun 16, 2025
@joydddd
Expose tile.id
9fe2aec 
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from main to joydddd/stack/3 June 16, 2025 23:31
@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:37
joydddd added a commit that referenced this pull request Jun 16, 2025
@joydddd
Expose tile.id
504183d 
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from main to joydddd/stack/3 June 16, 2025 23:37
@joydddd joydddd requested review from jansel, yf225 and drisspg June 16, 2025 23:37
joydddd added a commit that referenced this pull request Jun 16, 2025
@joydddd
Expose tile.id
f1c151b 
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd changed the base branch from joydddd/stack/3 to main June 16, 2025 23:42
@joydddd
Expose tile.id
b819dad 
stack-info: PR: #188, branch: joydddd/stack/4
@joydddd joydddd mentioned this pull request Jun 16, 2025
Draft
drisspg
drisspg approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joydddd joydddd merged commit feb86dc into main Jun 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansel jansel Awaiting requested review from jansel

@yf225 yf225 Awaiting requested review from yf225

@drisspg drisspg Awaiting requested review from drisspg

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joydddd @drisspg @facebook-github-bot