Skip to content

Clean up WeightRow in preparation for optimizer state offloading #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Apr 24, 2025

Summary:

  • Clean up WeightRow implementation in preparation for optimizer state offloading
  • Add documentation for the class

Differential Revision: D73473546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 4d35e15
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/68156f4264dd250008623c8f
😎 Deploy Preview https://deploy-preview-4021--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the export-D73473546 branch 4 times, most recently from 5afcdf0 to bdf4726 Compare April 25, 2025 18:51
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

@q10 q10 force-pushed the export-D73473546 branch from bdf4726 to 96c6a47 Compare April 25, 2025 18:51
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from 96c6a47 to c1ccb51 Compare April 25, 2025 18:58
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from c1ccb51 to 88c5cdd Compare April 25, 2025 19:02
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch 2 times, most recently from 2e7ddaf to 174e1da Compare April 25, 2025 21:29
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from 174e1da to 7695283 Compare April 25, 2025 21:30
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from 7695283 to a9a88db Compare April 25, 2025 21:33
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from a9a88db to 174d20f Compare April 25, 2025 21:38
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 25, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
q10 added a commit to q10/FBGEMM that referenced this pull request Apr 29, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from cbab7e2 to 8fabde4 Compare April 29, 2025 20:07
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request Apr 29, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch 2 times, most recently from a509c59 to 14ecd19 Compare May 1, 2025 00:11
q10 added a commit to q10/FBGEMM that referenced this pull request May 1, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request May 2, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from 14ecd19 to 728d25c Compare May 2, 2025 19:17
q10 added a commit to q10/FBGEMM that referenced this pull request May 2, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from 728d25c to 844c844 Compare May 2, 2025 19:18
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

q10 added a commit to q10/FBGEMM that referenced this pull request May 2, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from 844c844 to 7c26a0f Compare May 2, 2025 19:21
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

@q10 q10 force-pushed the export-D73473546 branch from 7c26a0f to 8735e33 Compare May 2, 2025 19:38
q10 added a commit to q10/FBGEMM that referenced this pull request May 2, 2025
…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Differential Revision: D73473546
q10 added a commit to q10/FBGEMM that referenced this pull request May 3, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Reviewed By: sryap

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from 8735e33 to afd2001 Compare May 3, 2025 01:16
q10 added a commit to q10/FBGEMM that referenced this pull request May 3, 2025
…ytorch#4021)

Summary:

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Reviewed By: sryap

Differential Revision: D73473546
@q10 q10 force-pushed the export-D73473546 branch from afd2001 to f1c69c5 Compare May 3, 2025 01:17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

…ytorch#4021)

Summary:
Pull Request resolved: pytorch#4021

X-link: facebookresearch/FBGEMM#1109

- Clean up `WeightRow` implementation in preparation for optimizer state offloading
- Add documentation for the class

Reviewed By: sryap

Differential Revision: D73473546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73473546

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 24bc151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants