Optimize if-statements with if-constexpr #4022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D73678501 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 25, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 28, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Reviewed By: sryap, spcyppt Differential Revision: D73678501
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 28, 2025
Summary: - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Reviewed By: sryap, spcyppt Differential Revision: D73678501
|
This pull request was exported from Phabricator. Differential Revision: D73678501 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Apr 28, 2025
Summary: Pull Request resolved: pytorch#4022 - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Reviewed By: sryap, spcyppt Differential Revision: D73678501
Summary: X-link: facebookresearch/FBGEMM#1110 Pull Request resolved: pytorch#4022 - Replace if-statements with if-constexpr blocks to optimize out some code branches completely. This is to facilitate `WeightRow` class cleanups - Replace uses of WeightRow with WeightRowAccessor where cache loading and eviction are not used Reviewed By: sryap, spcyppt Differential Revision: D73678501
|
This pull request was exported from Phabricator. Differential Revision: D73678501 |
|
This pull request has been merged in a0ec2bb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replace if-statements with if-constexpr blocks to optimize out some code
branches completely. This is to facilitate
WeightRowclass cleanupsReplace uses of WeightRow with WeightRowAccessor where cache loading and
eviction are not used
Differential Revision: D73678501