update float8 training readme to include time measurement #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2291
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 0eb0616 with merge base dd43f16 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: Update the float8 training example code snippet to include time measurement that properly excludes torch.compile one-time warmup. Also, use larger shapes to demonstrate speedup from float8. Test Plan: copy-paste the snippet and run it, it works. Commenting out float8 shows a slowdown, as expected. Reviewers: Subscribers: Tasks: Tags:
vkuzo
force-pushed
the
20250603_float8_readme_update
branch
from
d408aef to
0eb0616
Compare
drisspg
approved these changes
Jun 3, 2025
danielvegamyhre
approved these changes
Jun 3, 2025
vkuzo
added
the
topic: documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update the float8 training example code snippet to include time measurement that properly excludes torch.compile one-time warmup. Also, use larger shapes to demonstrate speedup from float8.
Test Plan:
copy-paste the snippet and run it, it works. Commenting out float8 shows a slowdown, as expected.
Reviewers:
Subscribers:
Tasks:
Tags: