Skip to content

make bfs_graph_trace as internal function #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make bfs_graph_trace as internal function #2294

wants to merge 1 commit into from

Conversation

Gasoonjia
Copy link
Contributor

Summary: makes bfs_trace_with_node_process as a internal graph utils.

Differential Revision: D75888360

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2294

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7a35c5e with merge base a2c5ca1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75888360

Gasoonjia added a commit to Gasoonjia/ao that referenced this pull request Jun 3, 2025
@Gasoonjia @facebook-github-bot
make bfs_graph_trace as internal function (pytorch#2294)
e7703d4 
Summary:

makes bfs_trace_with_node_process as a internal graph utils.

Differential Revision: D75888360
@larryliu0820
Copy link
Contributor

Looks ok to me? @jerryzh168

@Gasoonjia @facebook-github-bot
make bfs_graph_trace as internal function (pytorch#2294)
7a35c5e 
Summary:
Pull Request resolved: pytorch#2294

makes bfs_trace_with_node_process as a internal graph utils.

Reviewed By: larryliu0820

Differential Revision: D75888360
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75888360

@Gasoonjia
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 3, 2025

Didn't find following labels among repository labels: release notes: none

@Gasoonjia
Copy link
Contributor Author

what's the best release note for this pr? it introduces BC issue for users and should have a release note label.

@janeyx99 janeyx99 added the topic: bc-breaking Use this tag if this PR breaks backward compatibility label Jun 3, 2025
janeyx99
janeyx99 reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please do write a BC breaking note for the PR body for best visibility. The reason for it becoming private would be that it was never intended to be public and that the usage of this function by end users is not expected to be high.

jerryzh168
jerryzh168 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see an example for bc-breaking note here: #1865

but I don't think there are users using this right now so probably OK to skip as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 left review comments

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: bc-breaking Use this tag if this PR breaks backward compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gasoonjia @facebook-github-bot @larryliu0820 @jerryzh168 @janeyx99