-
Notifications
You must be signed in to change notification settings - Fork 353
add FreeBSD support #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FreeBSD support #172
Conversation
19c60f5
to
c57c80f
Compare
The testcase below fails with a "Floating point exception" with this patch on FreeBSD 13.2.
|
@yurivict
Can you try to reproduce on main branch of pytorch with cpuinfo replaced with my version. |
I tried with the recent release 2.0.1 |
Recompile with pytorch 2.0.1 should work, and debug your code with valgrind, paste the result here. |
Here is what cgdb screen looks like at the moment of failure:
|
|
Unfortunately, |
9c60525
to
38bd8cf
Compare
@yurivict I could reproduce the error in another host and it is fixed. |
6ffb02e
to
7948b28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reformat all files and line to use tabs
It's not what I have after 5 patches:
Maybe you need to squash the commits. |
@yurivict The history is somewhat messy. Can you remove the local repository and re-clone? I would squash until it is stable |
Sorry, I had not all patches applied before. |
@yurivict Grad to see that. What is your CPU utility? Can all core reach 100%? |
This example prints that |
in Pytorch c10/core/thread_pool.h line 42 |
9fbf366
to
5eaca7a
Compare
@Maratyszcza Most of listed issues have been fixed except the cores, which is returned by FreeeBSD, can you help review again? |
I no longer maintain this project, maybe @malfet or @fbarchard could review? |
@fbarchard Help merge it? |
@malfet Help merge it? |
static inline uint32_t bit_mask(uint32_t bits) { | ||
return (UINT32_C(1) << bits) - UINT32_C(1); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps as followup: as it's present in linux/init.c, mach/init.c and windows/init.c shouldn't it be moved to internal-api.h?
The |
The support is still experimental. |
I still think you should publish it. Just mention that it is experimental. |
No description provided.