[Executorch][SDPA] Refactor + Make quantized sdpa handle sequence at dim 1 or 2 #9943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dim 1 or 2 For quantized SDPA we want to evaluate performance impact of having seq at dim 1 as well as dim 2. This diff refactors the code to enable this. The same should be done also for float SDPA but left for future. Differential Revision: [D71833060](https://our.internmc.facebook.com/intern/diff/D71833060/) [ghstack-poisoned]
kimishpatel
requested review from
jackzhxng,
iseeyuan,
larryliu0820 and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9943
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 6cafa6a with merge base ad6f5ee ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 7, 2025
|
This pull request was exported from Phabricator. Differential Revision: D71833060 |
kimishpatel
added
the
release notes: examples
facebook-github-bot
added
the
CLA Signed
…equence at dim 1 or 2" For quantized SDPA we want to evaluate performance impact of having seq at dim 1 as well as dim 2. This diff refactors the code to enable this. The same should be done also for float SDPA but left for future. Differential Revision: [D71833060](https://our.internmc.facebook.com/intern/diff/D71833060/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D71833060 |
kirklandsign
approved these changes
Apr 9, 2025
…equence at dim 1 or 2" For quantized SDPA we want to evaluate performance impact of having seq at dim 1 as well as dim 2. This diff refactors the code to enable this. The same should be done also for float SDPA but left for future. Differential Revision: [D71833060](https://our.internmc.facebook.com/intern/diff/D71833060/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D71833060 |
…equence at dim 1 or 2" For quantized SDPA we want to evaluate performance impact of having seq at dim 1 as well as dim 2. This diff refactors the code to enable this. The same should be done also for float SDPA but left for future. Differential Revision: [D71833060](https://our.internmc.facebook.com/intern/diff/D71833060/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D71833060 |
facebook-github-bot
merged commit acd6b1c
into
gh/kimishpatel/170/base
82 of 84 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For quantized SDPA we want to evaluate performance impact of having seq at dim 1 as well as dim 2.
This diff refactors the code to enable this.
The same should be done also for float SDPA but left for future.
Differential Revision: D71833060