support bucket offsets and sizes in shard metadata #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D72702173 |
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Apr 12, 2025
…harding (pytorch#2884) Summary: Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72702173
faran928
force-pushed
the
export-D72702173
branch
from
7c9b90f to
4551f07
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72702173 |
Differential Revision: D72263389
…harding (pytorch#2884) Summary: Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72702173
faran928
force-pushed
the
export-D72702173
branch
from
4551f07 to
71554bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D72702173 |
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Apr 13, 2025
…harding (pytorch#2884) Summary: Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 13, 2025
…ucket wise sharding (pytorch#151192) Summary: X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Apr 13, 2025
…harding (pytorch#2885) Summary: X-link: pytorch/pytorch#151192 Pull Request resolved: pytorch#2885 Pull Request resolved: pytorch#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 13, 2025
…ucket wise sharding (pytorch#151192) Summary: Pull Request resolved: pytorch#151192 X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 13, 2025
…ucket wise sharding (pytorch#151192) Summary: X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 13, 2025
…ucket wise sharding (pytorch#151192) Summary: X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 13, 2025
…ucket wise sharding (pytorch#151192) Summary: Pull Request resolved: pytorch#151192 X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Apr 13, 2025
…harding (pytorch#2885) Summary: X-link: pytorch/pytorch#151192 Pull Request resolved: pytorch#2885 Pull Request resolved: pytorch#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 13, 2025
…ucket wise sharding (pytorch#151192) Summary: X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Apr 13, 2025
…harding (pytorch#2885) Summary: X-link: pytorch/pytorch#151192 Pull Request resolved: pytorch#2885 Pull Request resolved: pytorch#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 13, 2025
…ucket wise sharding (pytorch#151192) Summary: Pull Request resolved: pytorch#151192 X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 15, 2025
…ucket wise sharding (pytorch#151192) Summary: X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Apr 15, 2025
…harding (pytorch#2885) Summary: X-link: pytorch/pytorch#151192 Pull Request resolved: pytorch#2885 Pull Request resolved: pytorch#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 15, 2025
…ucket wise sharding (pytorch#151192) Summary: Pull Request resolved: pytorch#151192 X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 15, 2025
…ucket wise sharding (pytorch#151192) Summary: X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
faran928
added a commit
to faran928/torchrec
that referenced
this pull request
Apr 15, 2025
…harding (pytorch#2885) Summary: X-link: pytorch/pytorch#151192 Pull Request resolved: pytorch#2885 Pull Request resolved: pytorch#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Differential Revision: D72921209
faran928
added a commit
to faran928/pytorch
that referenced
this pull request
Apr 15, 2025
…ucket wise sharding (pytorch#151192) Summary: Pull Request resolved: pytorch#151192 X-link: pytorch/torchrec#2885 X-link: pytorch/torchrec#2884 Bucket offsets and sizes in torchrec shard metadata for bucket wise sharding for ZCH v.Next Test Plan: buck test torchrec/distributed/tests:test_sharding_plan Differential Revision: D72921209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D72702173