minior refactoring and adding comments to the TrainPipelineSparseDist #2898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63793825 |
TroyGarden
force-pushed
the
export-D63793825
branch
from
17ea61c to
137e5da
Compare
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Apr 20, 2025
…pytorch#2898) Summary: # context * add in-code comments to the train_pipeline.TrainPipelineSparseDist to explain the actions in the sparse dist pipeline. * minior refactoring: change `_pipelined_forward_type` as the class variable instead of instance variable since it's always constant in the class init. Differential Revision: D63793825
|
This pull request was exported from Phabricator. Differential Revision: D63793825 |
…pytorch#2898) Summary: # context * add in-code comments to the train_pipeline.TrainPipelineSparseDist to explain the actions in the sparse dist pipeline. * minior refactoring: change `_pipelined_forward_type` as the class variable instead of instance variable since it's always constant in the class init. Differential Revision: D63793825
TroyGarden
force-pushed
the
export-D63793825
branch
from
137e5da to
02e86af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63793825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
_pipelined_forward_typeas the class variable instead of instance variable since it's always constant in the class init.Differential Revision: D63793825