Skip to content

Perturbation Sampling for PSF #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from
Draft

Conversation

Marvin-Beckmann
Copy link
Member

Description

This PR implements will add perturbation sampling for presampling. This makes it possible to more efficiently sample generate signatures.

  • Fix length of signatures generated using presampling (reason yet to be determined)
  • Finish documentation and test

Testing

  • I added basic working examples (possibly in doc-comment)
  • I triggered all possible errors in my test in every possible way
  • I included tests for all reasonable edge cases
  • I provided an intuition regarding how certain inputs have to be set
  • Add a benchmark with large parameters close to proposed parameters in papers

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide
    • I have credited related sources if needed

@Marvin-Beckmann Marvin-Beckmann self-assigned this Oct 29, 2024
@Marvin-Beckmann Marvin-Beckmann added the enhancement📈 New feature or request label Oct 29, 2024
@jnsiemer jnsiemer force-pushed the perturbation_sampling branch from 3d0416d to caf4744 Compare January 17, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement📈 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants