Add & Sub between MatQ & MatZ
#489
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcel583
requested changes
Mar 24, 2025
src/rational/mat_q/arithmetic/add.rs
Outdated
Comment on lines
101
to
103
| /// let a = MatQ::from_str("[[1/2, 2/3, 3/4],[3/4, 4/5, 5/7]]").unwrap(); | ||
| /// let b = MatQ::from_str("[[1/4, 9/7, 3/7],[1, 0, 5]]").unwrap(); | ||
| /// let c = MatZ::identity(2, 3); |
There was a problem hiding this comment.
Suggested change
| /// let a = MatQ::from_str("[[1/2, 2/3, 3/4],[3/4, 4/5, 5/7]]").unwrap(); | |
| /// let b = MatQ::from_str("[[1/4, 9/7, 3/7],[1, 0, 5]]").unwrap(); | |
| /// let c = MatZ::identity(2, 3); |
There was a problem hiding this comment.
I don't understand this comment. If I remove these lines, the doc-comment is invalid. What is the suggestion here?
There was a problem hiding this comment.
Ah, I think I got it. I divided the doc-test into the two doc-comments.
jnsiemer
force-pushed
the
arithmetic_matq_matz
branch
from
2e3b237 to
5f54f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements...
addandsubforMatQandMatZNo additional tests required as the function uses the
add_safe/sub_safewhich is already tested.