-
Notifications
You must be signed in to change notification settings - Fork 2
Add unsafe
Setters
#491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jnsiemer
wants to merge
8
commits into
dev
Choose a base branch
from
unsafe_setters
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+583
−23
Open
Add unsafe
Setters
#491
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d5d882e
Implement macros for unsafe_setters
jnsiemer b016781
Implement unsafe setters for integer structs
jnsiemer d4c64b9
Implement unsafe setters for modulus structs
jnsiemer e196a14
Implement unsafe setters for residual classes
jnsiemer 49605c0
Implement unsafe setters for rational types
jnsiemer 6527321
Apply suggestions from code review
jnsiemer 890add8
Minor comment update
jnsiemer 30920a2
Make clippy happy
jnsiemer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it work for multiple references?
You say that the function only works if no other references exist/are used in the comment. But is there no way to rewrite the function such that it does? Or is it just too much for us to implement right now?
I tried this, but it did not work:
/// Checks if setter works for all references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have loved to implement this. Unfortunately, you can't change the object that a Reference Counter (Rc), which we implement our Modulus objects with, retrospectively.
As I wasn't able to find out which objects point to the Modulus object (I believe that the data-structure internally only keeps a reference from the object pointing to the Rc, which would be absolutely sensible), it could be possible that this is impossible if you don't want to do a search for a reference to that Rc and replace the pointer. Also in this case, I wouldn't know how to do it and it seems very inefficient.
Thus, I settled for this solution for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, not possible. You would need additional modifications to the baseline. The Rc provides immutable access to the content of the reference counter.
This is also why modification as here needs to drop the current RC and essentially needs to instantiate a new counter.
What you could do is provide a Rc to an fmpz_mod_ctx object instead of the context object itself - then you could get the desired behavior