Skip to content

Added Display IGT Test #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

manasab-qli
Copy link

Description:
This script automates the validation of authentication mechanisms within the IGT Core framework. It performs a series of tests to ensure that the authentication processes are functioning correctly and securely. The script captures detailed logs and provides a summary of the test results.

Signed-off-by: Manasa Bethapalli <[email protected]>
Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is missing

echo "Checking if dependency binary is available"

# Set the library path for the IGT tests
LD_LIBRARY_PATH=/data/igt/lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether the path exists

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the check in next commit

export LD_LIBRARY_PATH

# Navigate to the directory containing the IGT tests
cd /data/igt/tests/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether the path exists

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the check in next commit

cd /data/igt/tests/

# Run the core_auth test and log the output to a file
./core_auth 2>&1 | tee /data/core_auth_log.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensude /data/ directory exists before saving logs there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the check in next commit

else
# If "SUCCESS" is not found, print that the test failed
log_pass "$TESTNAME : Test Failed"
echo "$TESTNAME Fail" > $test_path/$TESTNAME.res
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Fail/FAIL/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the check in next commit

./core_auth 2>&1 | tee /data/core_auth_log.txt

# Check the log file for the string "SUCCESS" to determine if the test passed
if grep -q "SUCCESS" /data/core_auth_log.txt; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how the logs look like. Is there just one SUCCESS string? Can there be both SUCCESS and FAILURE in the same log file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will have only success
cant have both success and failure

@@ -0,0 +1,68 @@
Sure, here is a README for the IGT Core Auth Test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Seems unneccessary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the check in next commit

1. Copy the script to your target system and make it executable:

```bash
chmod +x igt_core_auth_test.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not part of the PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the check in next commit

2. Run the script:

```bash
./igt_core_auth_test.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not part of the PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is renamed to run.sh to maintain the same convention.
readme will also updated in the same way. in the commit this has been taken care

## Output

- **Test Logs**: Stored in individual files for each test variant.
- **Kernel Logs**: Captured via `dmesg` and `syslog`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dmesg and syslog are not used anywhere in the test script

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the check in next commit

Addressed the comments

Signed-off-by: manasab-qli <[email protected]>
addressed comments

Signed-off-by: manasab-qli <[email protected]>
@manasab-qli manasab-qli requested a review from mwasilew May 14, 2025 06:09
@mwasilew
Copy link
Contributor

Please squash the commits. There is no need to have 3 instead of 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants