Skip to content

Public CI Graphics GLMark2 Shell Scripts. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maheswaqcom
Copy link

Implemented shell scripts for public CI for Graphics GLMark2.
Added Graphics GLMark2 script
Added readme document for Graphics validation

Implemented shell scripts for public CI for Graphics GLMark2.
Added Graphics GLMark2 script
Added readme document for Graphics validation

Signed-off-by: maheswa <[email protected]>
Copy link
Contributor

@mwasilew mwasilew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your signed-off-by with real name, not user ID.

The commit message should explain why this test was added. I think the current one is decent, but if you could explain why this test is needed it would be appreciated.

if ! command -v /usr/bin/glmark2-es2-wayland &> /dev/null; then
echo -e "${RED}[ERROR]${NC} glmark2-es2-wayland not found in system path."
log_fail "$TESTNAME : glmark2-es2-wayland binary not found"
echo "$TESTNAME SKIP " > "$test_path/$TESTNAME.res"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove whitespace after SKIP

mkdir -p results/glmark2
chmod -R 755 results/glmark2

# Start logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these logs used in the test (scanning for kernel warning or sth like this)? If not, please remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants