Skip to content

Align gen_partition.py with an original script hosted on git.codelinaro.org #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MrCry0
Copy link

@MrCry0 MrCry0 commented Apr 10, 2025

This fixes #1

This backported commit adds support of option "-m" missing in the initially imported utility.

Original commit: https://git.codelinaro.org/clo/le/meta-qti-bsp/-/commit/b920abedc2ec26f2e32e965b31d3338ec606ce6e

Fixes: 7586c81 ("Import gen_partition.py utility")

Changes tested by generating xml scheme from live qcm6490-partitions.conf.

@MrCry0 MrCry0 requested a review from ndechesne as a code owner April 10, 2025 19:19
Copy link
Contributor

@ndechesne ndechesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the signed-off tag of the original author?

Also, while you are at it.. can you add a patch that describes better what this mapping command does? perhaps provide an example of the mapping file, so that users don't need to read the code to learn how to use it? Documenting inline should be fine for now.

This backported commit adds support of option "-m" missing in the initially
imported utility.

Original commit: https://git.codelinaro.org/clo/le/meta-qti-bsp/-/commit/b920abedc2ec26f2e32e965b31d3338ec606ce6e

Now gen_partition.py will take input file, output xml and
partition-imagefile mapping that a user passes through command line.
output xml will have image filenames set by user mapped to partitions
rather than the entries specified in the input conf file if -m is specified.

Signed-off-by: Divya Theja <[email protected]>

Fixes: 7586c81 ("Import gen_partition.py utility")
Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0
Copy link
Author

MrCry0 commented Apr 12, 2025

Can you please add the signed-off tag of the original author?

Done

Also, while you are at it.. can you add a patch that describes better what this mapping command does? perhaps provide an example of the mapping file, so that users don't need to read the code to learn how to use it? Documenting inline should be fine for now.

The -m option is already documented in Usage:

$ ./gen_partition.py 

	Usage: ./gen_partition.py -i <input> -o <output> -m [partition_name1=image_filename1,partition_name2=image_filename2,...]
	Version 1.0

It maps partitions from the input config file to alternative image files - it is useful if one needs to use an original config file replacing few or even one partition source.
Let me know if you think it's not enough and I'll add a better description, may be with an example of usage.

@MrCry0 MrCry0 force-pushed the main-gen_partition-restored branch from 38ef7e6 to 71f08f4 Compare April 12, 2025 18:43
@@ -64,6 +64,8 @@ def usage():
# store entries read from input file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove empty lines between SoB and the following up Fixes tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure scripts match the qclinux repos
3 participants