-
Notifications
You must be signed in to change notification settings - Fork 351
Improve pre/post render script logging #12444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d5dc015
to
c5a2169
Compare
@cderv I'm pushing this to v1.8 but feel free to move back to v1.7 if you've made the changes we talked about last week. |
This will allows scripts to be quiet
which seems a better way to take into account `quiet` option in addition to progress.
c5a2169
to
45c8580
Compare
I rebased - this is where I was. |
Right - we had talked about using |
Yeah I used more verbose env var name because I feel those two are too generic... We are in It does not apply to A border topic.
I have done that part by removing the Let's continue in 1.8 then. |
This is an idea coming from work on
The logging was not completely explicit as it was showing on script name without context.
This PR adds
Running script
before.Also it introduces an idea: Set a new env var so that the pre/post render script know when then need to make there option
console.log
quiet.If this seems a good idea, I can add test.
Comment on the process
I initially did some commit to add the env var with others
quarto-cli/src/command/render/project.ts
Lines 326 to 331 in d5dc015
but in fact, it seems better to defined closer to its meaning,
quarto-cli/src/command/render/project.ts
Lines 974 to 977 in d5dc015
which leads to
QUARTO_PROJECT_SCRIPT_PROGRESS
is set to 1 means progress can be shownQUARTO_PROJECT_SCRIPT_PROGRESS
is unset, means no progress is expected