Skip to content

[chore] no console.log anymore in our codebase #12476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Apr 7, 2025

This PR removes all instances of console.log that we can from our code base. From there, we should be able to add a pre-commit hook that disallows the string console.log. That's fairly extreme but I'm sick of accidentally checking these in myself 🤦

Places where they remain:

  • Code that isn't ours:
    • src/vendor
    • src/resources/vendor
  • Code that doesn't run in our binaries
    • package
    • tests
    • tools

In some places we want console output. For that, we have the debugPrint function, and we can always use the awkward syntax console["log"], etc.

@cscheid cscheid added this to the v1.8 milestone Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant