Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-vite, app-webpack): configure env files programatically #17960

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jclaveau
Copy link
Contributor

@jclaveau jclaveau commented Apr 8, 2025

This gives all the flexibility required to fully customize the process of loading env files like

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
    • => I have no Cordova App to test it
  • It's been tested on an Electron app
    • => I have no Electorn App to test it
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.
    • => The types have been updated, I guess it will update the docs

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

I have not been able to find any unit test for the config so I assumed it is not tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant