fix(ui): set disable prop default to false quasarframework#17945 #17962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
This PR aims to solve the bug described in issue #17945, setting a false default for disable prop.
As per Vue docs, all props are optional by default and an absent prop other than Boolean will have undefined value. In this scenario, a Boolean prop willl be cast to false, unless an undefined value is explicitly passed.
Setting a default to false prevents hybrid behaviours described in the linked issue because false value (our default) will be used if the resolved value is undefined, including both when the prop is missing or explicit undefined is passed
Further reference can be found in the aforementioned doc: https://vuejs.org/guide/components/props.html#prop-validation