Add Gemma3 #390
Draft
Add Gemma3 #390
+1,716
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaddi
requested review from
quic-rishinr,
ochougul and
quic-amitraj
as code owners
Closed
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]> Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Rishin Raj <[email protected]> Signed-off-by: Mohit Soni <[email protected]> Signed-off-by: Abukhoyer Shaik <[email protected]> Signed-off-by: Asmita Goswami <[email protected]> Signed-off-by: vbaddi <[email protected]> Signed-off-by: Meet Patel <[email protected]> Co-authored-by: Rishin Raj <[email protected]> Co-authored-by: Abukhoyer Shaik <[email protected]> Co-authored-by: asmigosw <[email protected]> Co-authored-by: Vinayak Baddi <[email protected]> Co-authored-by: Meet Patel <[email protected]> Signed-off-by: Mohit Soni <[email protected]>
This reverts commit 70ae12f. Signed-off-by: Mohit Soni <[email protected]>
Signed-off-by: Mohit Soni <[email protected]> Signed-off-by: Mohit Soni <[email protected]>
| chunk_inputs["input_ids"] = lang_inputs["input_ids"][:, i * prefill_seq_len : (i + 1) * prefill_seq_len] | ||
| chunk_inputs["position_ids"] = lang_inputs["position_ids"][ | ||
| :, i * prefill_seq_len : (i + 1) * prefill_seq_len | ||
| ] | ||
| outputs = lang_session.run(chunk_inputs) | ||
| chunk_inputs["index"] = outputs["index_output"] |
There was a problem hiding this comment.
Could you explain what are chunk_inputs["index"] and outputs["index_output"]?
Also, with the new approach, is batching supported?
Signed-off-by: vbaddi <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Dipankar Sarkar <[email protected]>
Signed-off-by: Ann <[email protected]>
| node_precision_info="fp32_nodes_gemma3_4b_text.yaml", | ||
| ) | ||
| print(f"qpc path is {qpc_path}") | ||
| exec_info = qeff_model.generate(tokenizer, prompts=Constants.INPUT_STR, device_ids=[0]) |
There was a problem hiding this comment.
@qcdipankar Is match obtained between original torch and AIC? Please report the single layer match.
quic-rishinr
requested changes
Jun 9, 2025
| @@ -0,0 +1,48 @@ | |||
| # ----------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
We should not be having separate script for running Language model. Please remove the script and add example for running text only input, text + image input and text with multi image input using QEFFAutoModelForImageTextToText.
|
Please add the test, update the model in validated models list |
quic-rishinr
requested changes
Jun 9, 2025
| @@ -0,0 +1,6 @@ | |||
| # ----------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
please update it to
-----------------------------------------------------------------------------
Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
SPDX-License-Identifier: BSD-3-Clause
-----------------------------------------------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.