[QEff Finetune]: Enable --help for finetune CLI #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamta Singh <[email protected]>
quic-mamta
requested review from
quic-rishinr,
ochougul and
quic-amitraj
as code owners
quic-mamta
changed the title
Signed-off-by: Mamta Singh <[email protected]>
quic-meetkuma
suggested changes
Jun 4, 2025
| @@ -58,7 +59,8 @@ class TrainConfig: | |||
| model_name: str = "meta-llama/Llama-3.2-1B" | |||
| tokenizer_name: str = None # if not passed as an argument, it uses the value of model_name | |||
| run_validation: bool = True | |||
| batch_size_training: int = 1 | |||
| train_batch_size: int = 1 | |||
There was a problem hiding this comment.
if we are changing this param, may be an internal announcement is required. SIT team's testing commands might depend on this one.
quic-mamta
force-pushed
the
add_help
branch
2 times, most recently
from
3128d6e to
1ca1ab4
Compare
Signed-off-by: Mamta Singh <[email protected]>
quic-meetkuma
suggested changes
Jun 9, 2025
quic-mamta
force-pushed
the
add_help
branch
2 times, most recently
from
c9c4c6e to
f529f21
Compare
quic-swatia
reviewed
Jun 9, 2025
quic-mamta
force-pushed
the
add_help
branch
2 times, most recently
from
68316b0 to
5079464
Compare
Signed-off-by: Mamta Singh <[email protected]>
Signed-off-by: Mamta Singh <[email protected]>
quic-swatia
approved these changes
Jun 12, 2025
vbaddi
approved these changes
Jun 12, 2025
quic-rishinr
pushed a commit
that referenced
this pull request
Jun 12, 2025
1. Enabled --help for finetune 2. Updated finetune docs 3. removed unused flags --------- Signed-off-by: Mamta Singh <[email protected]> Co-authored-by: Mamta Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.