Llama4 chunked attention support #395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-hemagnih
approved these changes
May 8, 2025
|
What is the plan to merge this code changes, As we have cut the branch for 1.20 we can now plan to merge Llama4 changes in main branch. |
quic-rishinr
force-pushed
the
llama4
branch
4 times, most recently
from
f59f636 to
8a80c89
Compare
| @@ -929,6 +948,8 @@ def get_specializations( | |||
| "batch_size_times_num_tiles": batch_size_times_num_tiles, | |||
| "img_size": img_size, | |||
| "vision_size": vision_size, | |||
| "chunk_length": prefill_seq_len, | |||
| "chunk_ctx_len": chunk_ctx_len, | |||
There was a problem hiding this comment.
In specializations, we need total CL also, right? For nope layers KV.
| _, chunk_causal_mask = self._update_causal_mask( | ||
| attention_mask, inputs_embeds, cache_position, past_key_values, output_attentions | ||
| causal_mask = _create_causal_mask( | ||
| position_ids=position_ids, target_length=past_key_values.key_cache[3].shape[-2] |
There was a problem hiding this comment.
Here key_cache[3] instead of the hard coded value can we generalize using some config value.
| @@ -259,6 +259,151 @@ def update3D( | |||
|
|
|||
| return k_out, v_out | |||
|
|
|||
| def _sliding_update( | |||
There was a problem hiding this comment.
@asmigosw As we have discussed, please restructure this to reuse the hybrid cache function.
There was a problem hiding this comment.
Also please report the o/p match with reference, with a smaller config for chunked_window. It will be hard verifying for 8K, so for testing purpose, change the config.
quic-amitraj
force-pushed
the
add_llama4
branch
2 times, most recently
from
1066b4f to
d8a947a
Compare
Signed-off-by: vbaddi <[email protected]>
Signed-off-by: Rishin <[email protected]> Signed-off-by: Rishin Raj <[email protected]> Signed-off-by: Rishin <[email protected]>
Signed-off-by: Rishin <[email protected]> Signed-off-by: Rishin Raj <[email protected]> Signed-off-by: Rishin <[email protected]>
Signed-off-by: Rishin <[email protected]> Signed-off-by: Rishin Raj <[email protected]> Signed-off-by: Rishin <[email protected]>
Signed-off-by: Rishin <[email protected]> Signed-off-by: Rishin Raj <[email protected]> Signed-off-by: Rishin <[email protected]>
Signed-off-by: Rishin <[email protected]> Signed-off-by: Rishin Raj <[email protected]> Signed-off-by: Rishin <[email protected]>
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Rishin <[email protected]>
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Rishin <[email protected]>
Signed-off-by: Rishin <[email protected]>
Signed-off-by: Rishin <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]>
Signed-off-by: Ann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.