Features upgrade of Embedding model
#424
Draft
+228
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
…e closest seq_len based on input_ids_len Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
quic-amitraj
requested review from
quic-rishinr,
ochougul and
quic-hemagnih
as code owners
quic-amitraj
changed the title
Pooling support to Embedding ModelEmbedding model
quic-amitraj
changed the title
Embedding modelEmbedding model
quic-rishinr
reviewed
Jun 5, 2025
| @@ -662,3 +662,9 @@ def filter_kwargs(func, kwargs): | |||
| """ | |||
| valid_args = inspect.signature(func).parameters | |||
| return {key: value for key, value in kwargs.items() if key in valid_args} | |||
|
|
|||
|
|
|||
| def custom_format_warning(msg, category, *args, **kwargs): | |||
There was a problem hiding this comment.
@quic-hemagnih can we add it as part of logger module?
There was a problem hiding this comment.
I think its a good idea to notify user that pooling is appended to the model. We will add this to the logger as well but warning is also important here. What you think about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poolingsupport to Embedding ModelQEffAutoModel