-
Notifications
You must be signed in to change notification settings - Fork 9
build: add opt-in installation of QML lib #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please let me know if I should add an instruction to the README.md or BUILD.md (or anywhere else really). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you tested this and it actually works, given that I've got a couple nits.
Also yeah you could put it in build.md.
Yep, has been tested: qmllint without the QS lib
with the lib linked
Although I have some, presumably nix related, issues with qmllint finding the lib, but that also happened with the builtin QML features, so I think it is unrelated. Will implement the feedback |
041b36f
to
2ba8f11
Compare
Override the package with `withQMLLib = true;` to enable lib installation, alternatively add `-DINSTALL_QML_LIB=ON` to your cmake build command. Co-authored-by: a-usr <[email protected]>
I applied all requests |
Alright, LGTM. Do keep in mind that qmllint/qmlls are not entirely accurate in the context of quickshell, as quickshell papers over some oddities like qmldir files even needing to exist. |
Alright, noted! Thanks for the approval |
Hey, this follows our conversation on Matrix regarding lsp and linting support, while maybe not a desired default feature, it might be interesting to expose an option for folks to enable if they do want to give that a shot.
Override the package with
withQMLLib = true;
to enable lib installation, alternatively add-DINSTALL_QML_LIB=ON
to your cmake build command.