Add universal seat grab protocol. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
vaxerski
reviewed
May 23, 2025
| </description> | ||
| </event> | ||
|
|
||
| <request name="set_keyboard_surface"> |
There was a problem hiding this comment.
wouldn't it make sense to also give an (optional) pointer surface request?
There was a problem hiding this comment.
I'm not sure how much use a single pointer surface has. We could limit it to a set of surfaces but the client can also do that. I've matched the behavior to that of xdg_popup for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protocol allows grabs to be created for surfaces that aren't xdg popups.
This allows
I've included requests to deal with keyboard focus as it is handled in xdg popup's grab but the client could also be asked to interpret keyboard seat focus however it wants, though this makes it harder to use with toolkits.