Skip to content

accept * as field name #2555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

accept * as field name #2555

wants to merge 1 commit into from

Conversation

PSeitz
Copy link
Collaborator

@PSeitz PSeitz commented Dec 6, 2024

accept * as field name in the query parser

Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR lacks a lot of explanation.
The motivation to begin with.
I assume you want to add "*:" because quickwit relies on the tantivy grammar to build its AST and DDG includes *: in its syntax.

That info needs to be in the code (and if you want a longer background explanation in the commit message & PR description).

Also, this implementation raises a lot of question:

  • With this PR what happens for regular tantivy users with a *:hello query?
  • Is this behavior unit tested? Does it make sense?
  • What is happens for queries like, field*withastar:hello. Is this behavior good, is it unit tested?
  • What is happens for queries like, *fieldstartingwithastar:hello. Is this behavior good, is it unit tested?
  • What is happens for queries like, *fieldendingwithastar*:hello. Is this behavior good, is it unit tested?

A thing we could consider, is to have a different query grammar for quickwit/pomsky, or to make it possible for tantivy-grammar users to plug their our own definition of what a valid field name is.

@trinity-1686a
Copy link
Contributor

i'm not actually sure we need this anyway, in the situation where this seemed useful, the field name actually gets remapped to something else entirely, and we don't go through this query parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants