Skip to content

fix: styled modal alignment #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lolzivkovic
Copy link

@lolzivkovic lolzivkovic commented Jun 5, 2025

This PR fixes alignment issues with Modals when position is set to bottom or right

What is it?

  • Feature / enhancement
  • [*] Bug
  • Docs / tests
  • Other

Why is it needed?

When trying to use Modal a Sheet it does not align properly when position set is either bottom or right

Checklist:

  • [*] My code follows the developer guidelines of this project
  • [*] I have performed a self-review of my own code
  • [*] I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Jun 5, 2025

🦋 Changeset detected

Latest commit: d19661b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@qwik-ui/styled Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 5, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lolzivkovic lolzivkovic changed the title fix: styled modal aligning to either left/top when position set eithe… fix: styled modal alignment Jun 5, 2025
@lolzivkovic
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@maiieul
Copy link
Contributor

maiieul commented Jun 6, 2025

Hey @lolzivkovic thanks for the submission! I tried it out locally and can't see any difference with your added changes. Could you share a screenshot?

@lolzivkovic
Copy link
Author

Hi @maiieul,

Of course, here are the changes and how they are reflected

Here is what it looks like in Firefox(139.0.1):
Before:
Screenshot From 2025-06-08 15-04-25

After:
Screenshot From 2025-06-08 15-03-43

Here is what it looks like in Chromium(137.0.7151.68):
Before:
Screenshot From 2025-06-08 15-07-30

After:
Screenshot From 2025-06-08 15-07-48

Also ml-0, mr-0, mb-0 and mt-0 seem redundant as well after the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants