-
Notifications
You must be signed in to change notification settings - Fork 186
Parse settings prior to reading file to ensure Encoding is set #2805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 126 126
Lines 6935 6936 +1
=======================================
+ Hits 6910 6911 +1
Misses 25 25 ☔ View full report in Codecov by Sentry. |
The NEWS don't reveal it but this change means that |
Thanks, would you mind filing this as a new bug? |
Closes #2803