Skip to content

Parse settings prior to reading file to ensure Encoding is set #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 4, 2025

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2803

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (9fd693c) to head (70b5789).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2805   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         126      126           
  Lines        6935     6936    +1     
=======================================
+ Hits         6910     6911    +1     
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico changed the title Parse settings prior to readine file to ensure Encoding is set Parse settings prior to reading file to ensure Encoding is set Mar 3, 2025
AshesITR
AshesITR previously approved these changes Mar 3, 2025
@MichaelChirico MichaelChirico merged commit 500a38c into main Mar 4, 2025
21 checks passed
@MichaelChirico MichaelChirico deleted the settings-timing branch March 4, 2025 07:25
@bastistician
Copy link

The NEWS don't reveal it but this change means that ~/.lintr settings are no longer read when linting inline_data, e.g., lintr::lint(<R-code-as-string>), which is what Emacs-ESS uses to lint code in R buffers. So with the development version of lintr I'd only see notes from the default_linters.

@MichaelChirico
Copy link
Collaborator Author

Thanks, would you mind filing this as a new bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings$encoding used before set
4 participants