Skip to content

Implements pipe_register() #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Implements pipe_register() #115

merged 2 commits into from
Apr 30, 2025

Conversation

shikokuchuo
Copy link
Member

@shikokuchuo shikokuchuo commented Apr 16, 2025

Registers a callback to be run upon {add, remove} pipe events at a Socket.

@wch pls see if this meets your needs or you prefer anything to be tweaked.

Closes #114.

@shikokuchuo shikokuchuo marked this pull request as draft April 29, 2025 18:13
@shikokuchuo shikokuchuo marked this pull request as ready for review April 30, 2025 10:58
@shikokuchuo
Copy link
Member Author

This is very likely going to be useful for what we need, so I'm going ahead to merge this.

For reference, this registers the callback directly rather than with a 'promise' as it's triggered on a pipe event (connect, disconnect), and there's no object associated with it, unlike for example an 'aio', which can be turned into a 'promise'.

@shikokuchuo shikokuchuo merged commit d2bdfc1 into main Apr 30, 2025
13 checks passed
@shikokuchuo shikokuchuo deleted the pipe-cb branch April 30, 2025 11:11
shikokuchuo added a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a callback to be registered for pipe events
1 participant