Skip to content

fix: allow failure of building linux native binary #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2025

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Mar 22, 2025

Ref: #4 (comment)

The issue here is that native binaries may be required, but since subsequent Emscripten builds may succeed without them in fact (which is the case for the original Rust dependency package), we can simply allow the build to fail.

@jeroen
Copy link
Member

jeroen commented Mar 22, 2025

Wouldn't it still be useful to update the stable toolchain (if the parent image is very old)?

@eitsupi
Copy link
Contributor Author

eitsupi commented Mar 22, 2025

Sorry, I was mistaken. In fact, the nightly toolchain is set to default in the base image, so upgrating stable is not helpful.
https://github.com/r-wasm/webr/blob/69d6b0b5e77a9df27d4489df4600a46f7ebae56e/Dockerfile#L45

@jeroen jeroen merged commit 2efb0f1 into r-universe-org:master Mar 22, 2025
@eitsupi
Copy link
Contributor Author

eitsupi commented Mar 22, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants