-
Notifications
You must be signed in to change notification settings - Fork 280
Replace syntex with rustc-ap-syntax #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
with support for `use_nested_groups`
By rust-lang/rust#49718, ExprKind::TupField was removed. This commit includes a temorary fix and a tests for this removal.
Why is nightly required? |
@birkenfeld |
Why rustc-ap-syntax and not https://github.com/dtolnay/syn ? |
@davemilter
But, if you think there's any merit to use |
|
Thanks, this is great! |
I created |
Now
syntex_syntax
is no longer maintained, so we have to move towardslibsyntax
.Here I list up change from our current
syntex_syntax 52.0
andrustc-ap-syntax 133.0
(though not all).visit::Visitor
needs life time(now its declaration ispub trait Visitor<'ast>: Sized
)use
is completely differentExprKind::TupField
is removed by Hygiene 2.0: Avoid comparing fields by name rust-lang/rust#49718By this change, we become unable to compile racer with
beta
orstable
compiler.So we have to decide some things.
rustfmt-nightly
?syntex
branch?I constructed this PR from kngwyu#1 kngwyu#2 kngwyu@40466f6 and some commits.