Skip to content

Automated Resyntax fixes #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #733

wants to merge 7 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Apr 6, 2025

Resyntax fixed 20 issues in 3 files.

  • Fixed 7 occurrences of let-to-define
  • Fixed 7 occurrences of instantiate-to-new
  • Fixed 2 occurrences of instantiate-to-make-object
  • Fixed 1 occurrence of if-let-to-cond
  • Fixed 1 occurrence of if-begin-to-cond
  • Fixed 1 occurrence of map-to-for
  • Fixed 1 occurrence of cond-let-to-cond-define

resyntax-ci bot added 7 commits April 6, 2025 00:11
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
The `instantiate` form is for mixing positional and by-name constructor arguments. When no positional arguments are needed, use `new` instead.
The `instantiate` form is for mixing positional and by-name constructor arguments. When no by-name arguments are needed, use `make-object` instead.
Using `cond` instead of `if` here makes `begin` unnecessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants