-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me at least 👍
@@ -18,3 +18,81 @@ | |||
extern crate radicle_keystore as keystore; | |||
|
|||
pub mod credential; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of putting this code here, I'd suggest:
- Adding
pub mod remote_helper
here - Creating a
remote_helper.rs
file and moving this code into that file - Renaming the run_rad_remote_helper function to
run
- Invoking the function from main with
remote_helper::run()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout @cloudhead, this looks better organised now 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
For the project checkout feature we'll need to package the rad-remote-helper together with Upstream.
For this I looked into the following options:
Forcing Upstream to build the
git-helpers
binary from itsradicle-link
dependency, so far seems to be impossible in Cargo:Change Upstream proxy into a top-level Rust workspace and include
radicle-link
as a sub-component: not possible becauseradicle-link
is already organized as a workspace and nested workspaces are not allowed:Make upstream build and package scripts do a
cargo install --git https://github.com/radicle-dev/radicle-link.git --rev 269a7ededafd7373ebfb03210770d0b3778002f
: blows up build times both for devs and on CI because build artefacts are not shared between proxy and the external cargo install.Extracting the
git-remote-rad
functionality into a lib, so we can create a separate binary within Upstream that will be packaged along with proxy.This PR implements option nr. 4.