Skip to content
This repository was archived by the owner on Mar 25, 2024. It is now read-only.

Upgrade metadata filter #37

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Conversation

rmweir
Copy link
Contributor

@rmweir rmweir commented Dec 21, 2020

Problem:
Pods are restarting due to watch connections closing.

Update:
Update metadata filter to version that has logic to gracefully handle closed connections. This is the same fix as upstream:
fluent/fluentd-kubernetes-daemonset#495

Issue:
rancher/rancher#30425

Prior, was not using consraints for dependencies which causes
install to use the latest packages. This can cause inconsistent
builds at different times or on different machines despite
using the same config. Fluent and metadata filter are being
upgraded to match upstream and resolve pods restarting due to
not handling closed connections properly.
Copy link
Contributor

@cbron cbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok, seems like lots of unknowns here that we need to test out, both on dev and QA side.
Also we need to be wary of tagging this repo with 2.5.4 going out soon, and a previous tag from here going out with it.

@rmweir rmweir merged commit 999df6b into rancher:master Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants