Add example for servo motor via PWM #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Jul 12, 2021
lurch
reviewed
Jul 12, 2021
lurch
reviewed
Jul 12, 2021
lurch
reviewed
Oct 30, 2021
Comment on lines
+36
to
+37
| uint32_t source_hz = clock_get_hz(clk_sys); | ||
| uint freq = 50; |
lurch
reviewed
Oct 30, 2021
| sleep_ms(1000); | ||
| } | ||
|
|
||
| void servo_init(int gpio, int base_frequency) |
There was a problem hiding this comment.
This base_frequency parameter doesn't seem to actually be used anywhere??
lurch
reviewed
Oct 30, 2021
Comment on lines
+25
to
+26
| if(wait_write) | ||
| sleep_ms(1000); |
There was a problem hiding this comment.
This is documented as "@param wait_write Wait for write to finish", in which case 1000ms seems like an excessively long time? 🤷
There was a problem hiding this comment.
My motors are slow and with a smaller delay my motor do not finish the turn properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servo motor example
This example is an adapted version of the Micropython repository to be used easily in C.