Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sample to read the partition table #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add a sample to read the partition table #627
Changes from all commits
01001fa
a0ceb2b
d2883d1
1015067
8b87449
c5aa4c1
2496fe7
5681d71
0f96a36
9bdba25
7d9edfa
87eddec
bbb1656
8f3564d
ee6d8d6
b463a69
555ded5
9bce48c
b5c2fbe
0889622
8dd6b0e
b53dfbc
4822ae3
c5fd635
c88a23c
869bf75
4005c6f
8d1d467
ce5b409
d9909f9
ce6dda8
7edee22
1066f75
b118961
c37dcbe
9c19b3c
cda403e
a0e81bd
ff8d2b4
9eb7c33
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to how you have a function (
uf2_family_ids_join
) for creating the formatted family-ids string, I wonder if it might be worth pulling out a separate function for creating theS(%s%s) NSBOOT(%s%s) NS(%s%s)
part of this string? (which I believe you could then also use in the per-partition loop?) 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I was about to suggest that you could use
%c
instead of%s
in yourprintf
formatting, but then I realised that you can't do "empty string" when usingchar
😂